Make only root test_deps externally visible #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comius
approved these changes
Jul 12, 2024
All other test_deps targets implicitly require the root BUILD file for the `license` target for their default_applicable_licenses; therefore, users should only depend on the root test_deps target.
meteorcloudy
added a commit
to bazelbuild/rules_java
that referenced
this pull request
Jul 4, 2025
Fixing ``` $ bazel build //src/test/java/com/google/devtools/build/lib/query2/cquery:FilesOutputFormatterCallbackTest INFO: Invocation ID: a90dc4d1-9d48-4164-a9d1-7d82a393fc37 INFO: Options provided by the client: Inherited 'common' options: --isatty=1 --terminal_columns=170 INFO: Reading rc options for 'build' from /Users/pcloudy/workspace/bazel/.bazelrc: Inherited 'common' options: --enable_platform_specific_config --check_direct_dependencies=error --downloader_config=bazel_downloader.cfg INFO: Reading rc options for 'build' from /Users/pcloudy/workspace/bazel/.bazelrc: 'build' options: --java_runtime_version=21 --java_language_version=21 --tool_java_language_version=21 --tool_java_runtime_version=21 INFO: Reading rc options for 'build' from /Users/pcloudy/.bazelrc: 'build' options: --verbose_failures --announce_rc --disk_cache=/tmp/bazel_disk_cache --repository_cache=/tmp/bazel_repository_cache INFO: Found applicable config definition build:macos in file /Users/pcloudy/workspace/bazel/.bazelrc: --host_macos_minimum_os=10.13 --macos_minimum_os=10.13 --cxxopt=-std=c++17 --host_cxxopt=-std=c++17 --per_file_copt=external/.*@-w --host_per_file_copt=external/.*@-w DEBUG: /private/var/tmp/_bazel_pcloudy/829441223e9fec5a5a2e3d1dd743fdf0/external/grpc-java+/java_grpc_library.bzl:201:14: Multiple values in 'deps' is deprecated in build_bazel_remote_execution_v2_remote_execution_java_grpc ERROR: /private/var/tmp/_bazel_pcloudy/829441223e9fec5a5a2e3d1dd743fdf0/external/rules_java+/java/BUILD:78:10: in filegroup rule @@rules_java+//java:for_bazel_tests: Visibility error: target '@@bazel_skylib+//lib:test_deps' is not visible from target '@@rules_java+//java:for_bazel_tests' Recommendation: modify the visibility declaration if you think the dependency is legitimate. For more info see https://bazel.build/concepts/visibility ``` after upgrading bazel_skylib which contains bazelbuild/bazel-skylib#508
copybara-service bot
pushed a commit
to bazelbuild/rules_java
that referenced
this pull request
Jul 8, 2025
Fixing ``` $ bazel build //src/test/java/com/google/devtools/build/lib/query2/cquery:FilesOutputFormatterCallbackTest ... ERROR: /private/var/tmp/_bazel_pcloudy/829441223e9fec5a5a2e3d1dd743fdf0/external/rules_java+/java/BUILD:78:10: in filegroup rule @@rules_java+//java:for_bazel_tests: Visibility error: target '@@bazel_skylib+//lib:test_deps' is not visible from target '@@rules_java+//java:for_bazel_tests' Recommendation: modify the visibility declaration if you think the dependency is legitimate. For more info see https://bazel.build/concepts/visibility ``` after upgrading bazel_skylib which contains bazelbuild/bazel-skylib#508 Closes #306 COPYBARA_INTEGRATE_REVIEW=#306 from bazelbuild:meteorcloudy-patch-1 a0df97c PiperOrigin-RevId: 780484650 Change-Id: I1516310b78322eeb62d982a2e2a69d7ec756f925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other test_deps targets implicitly require the root BUILD file for the
licensetarget for their default_applicable_licenses; therefore, users should only depend on the root test_deps target.