Skip to content

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Oct 9, 2025

@bazel-io
Copy link
Member

bazel-io commented Oct 9, 2025

Hello @holzensp, @sitaktif, @KushalP, @shs96c, @bioball, @stackoverflow, modules you maintain (rules_pkl) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

bazel-io
bazel-io previously approved these changes Oct 10, 2025
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 10, 2025
@srueg srueg force-pushed the release-rules-pkl branch from 85c67b5 to 5d324f1 Compare October 13, 2025 09:59
@bazel-io bazel-io dismissed their stale review October 13, 2025 09:59

Require module maintainers' approval for newly pushed changes.

@srueg srueg requested a review from KushalP October 13, 2025 10:00
@srueg
Copy link
Contributor Author

srueg commented Oct 13, 2025

@bazel-io skip_check incompatible_flags

We're still on aspect_bazel_lib@2.13.0

bazel-io
bazel-io previously approved these changes Oct 13, 2025
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@KushalP
Copy link
Contributor

KushalP commented Oct 13, 2025

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Oct 13, 2025
KushalP
KushalP previously approved these changes Oct 13, 2025
@KushalP
Copy link
Contributor

KushalP commented Oct 13, 2025

@srueg you can't add a comment with the command, otherwise the bot gets confused. I've kicked it off, and approved.

@srueg
Copy link
Contributor Author

srueg commented Oct 14, 2025

@bazel-io skip_check incompatible_flags

@srueg srueg force-pushed the release-rules-pkl branch from 5d324f1 to bc9706b Compare October 14, 2025 14:34
@bazel-io bazel-io dismissed stale reviews from KushalP and themself October 14, 2025 14:35

Require module maintainers' approval for newly pushed changes.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@KushalP
Copy link
Contributor

KushalP commented Oct 14, 2025

@bazel-io help

@KushalP
Copy link
Contributor

KushalP commented Oct 14, 2025

@bazel-io skip_check incompatible_flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants