Skip to content

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @Bencodes, @restingbull, @nkoroste, modules you maintain (rules_kotlin) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@Bencodes
Copy link
Contributor

This one should be ready to merge now.

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Feb 28, 2025
@fmeum fmeum enabled auto-merge (squash) February 28, 2025 20:27
@ahumesky
Copy link
Contributor

ahumesky commented Mar 3, 2025

Looks like this glob doesn't match anything and is causing problems on bazel 8:
https://github.com/bazelbuild/rules_kotlin/blob/f6de6274430e8a6e1acd153ad02fb45ce911e0db/src/main/starlark/BUILD.release.bazel#L19

@ahumesky
Copy link
Contributor

rules_kotlin 2.1.3 is released which includes a commit that I believe should fix the bazel 8 issue with this PR: https://github.com/bazelbuild/rules_kotlin/releases/tag/v2.1.3

Can this PR be upsed to 2.1.3 or do we need a new one?

@kotlaja
Copy link
Collaborator

kotlaja commented Mar 24, 2025

Friendly ping @Bencodes, @restingbull, @nkoroste.

@Bencodes
Copy link
Contributor

@kotlaja a newer version has been merged, this PR can just be closed. #4053

@keith keith closed this Apr 30, 2025
auto-merge was automatically disabled April 30, 2025 16:12

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants