Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus-cpp@1.2.4 #1637

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 17, 2024

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (prometheus-cpp) have been updated in this PR. Please review the changes.

@mmorel-35 mmorel-35 changed the title Add prometheus-cpp v1.2.4 prometheus-cpp@1.2.4 Mar 17, 2024
@mmorel-35 mmorel-35 force-pushed the prometheus-cpp/v1.2.4 branch 2 times, most recently from c70db44 to d36252b Compare March 17, 2024 14:53
@mmorel-35 mmorel-35 requested a review from gjasny March 17, 2024 14:54
@mmorel-35 mmorel-35 force-pushed the prometheus-cpp/v1.2.4 branch 2 times, most recently from a02d498 to e5f2ec4 Compare March 17, 2024 18:17
gjasny
gjasny previously approved these changes Mar 17, 2024
@bazel-io bazel-io dismissed gjasny’s stale review March 18, 2024 08:00

Require module maintainers' approval for newly pushed changes.

gjasny
gjasny previously approved these changes Mar 18, 2024
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Mar 18, 2024
@bazel-io bazel-io dismissed gjasny’s stale review March 18, 2024 10:42

Require module maintainers' approval for newly pushed changes.

@mmorel-35
Copy link
Contributor Author

@meteorcloudy , any idea how to fix this ?

ERROR: Config value 'ssl' is not defined in any .rc file

There is a config ssl in https://github.com/jupp0r/prometheus-cpp/blob/v1.2.4/.bazelrc

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Mar 18, 2024

@gjasny ,
It seems like dev_dependency = True will need to be removed

@meteorcloudy
Copy link
Member

Or you don't build everything @prometheus-cpp//... (which probably includes the tests)

@mmorel-35 mmorel-35 force-pushed the prometheus-cpp/v1.2.4 branch 3 times, most recently from 672fcd1 to be3bbdc Compare March 18, 2024 12:51
gjasny
gjasny previously approved these changes Mar 18, 2024
@gjasny
Copy link

gjasny commented Mar 18, 2024

@meteorcloudy in the failed build run, why is bazel picking up the OpenSSL headers from /usr/local instead of boring ssl?

@fmeum
Copy link
Contributor

fmeum commented Mar 18, 2024

@gjasny This is caused by a Bazel bug: bazelbuild/bazel#10472 (comment)

@bazel-io bazel-io dismissed gjasny’s stale review March 19, 2024 10:05

Require module maintainers' approval for newly pushed changes.

@mmorel-35 mmorel-35 force-pushed the prometheus-cpp/v1.2.4 branch 2 times, most recently from 660caa8 to 05de5a4 Compare March 19, 2024 10:07
@meteorcloudy meteorcloudy merged commit 3cb88af into bazelbuild:main Mar 19, 2024
18 checks passed
@mmorel-35 mmorel-35 deleted the prometheus-cpp/v1.2.4 branch March 19, 2024 10:54
aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants