-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update bazel deps #4
chore: update bazel deps #4
Conversation
Also how do I set things to use
Which I have only seen with modules that lack |
Found how to request it
Have we tested the way the |
What you have should work as long as you have the proper BUILD and MODULE.bazel files in your external openssl. The current I'm tempted to remove it until there's some openssl rules or module in the official BCR. It was already requested once here: #3 Apparently there may be ways to improve this situation says one of the BCR maintainers bazelbuild/bazel-central-registry#1666 (comment)
I'm actively using The CI is configured to use |
What did you mean by this? What would proper look like. These are mine. BUILD.bazel
MODULE.bazel
Yeah I figured you tested it but just wanted to make sure. Is there anything obviously wrong about my files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
what you have for openssl looks fairly reasonable. You could try linking to your system installed I dug through my old private repo and I found out I used this BUILD file https://github.com/dropbox/dbx_build_tools/blob/master/thirdparty/openssl/BUILD.openssl by dropbox. It was before bzlmod was a thing though. |
Can you link me to the bzlmod version with boringssl? That openssl one looks like pretty similar in terms of target names. Also when I reference openssl in my project I do Ill try with the system one if I can't get this working. |
I think I figured it out. Edit: oh boringssl is already in the bazel central registry. |
@zaucy Will you be doing a new release to the registry for this? |
yep! should be in the registry now! |
thank you! |
I noticed these dependencies are out of date