Skip to content

Make SwiftSourceInfo accessible to optimize Swift index “jump to definition” #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kila2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make SwiftSourceInfo accessible to optimize Swift index “jump to definition” #954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions rules/framework/vfs_overlay.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,13 +240,25 @@ def _provided_vfs_swift_module_contents(swiftmodules, vfs_prefix, target_triple)
if swiftmodule_file == None or swiftmodule_file.is_source:
return None

swiftmoudles_file_infos = []
swiftsourceinfo_file = None
for file in swiftmodules:
swiftmoudles_file_infos.append((file.path, file.extension))
if file.extension == "swiftsourceinfo":
swiftsourceinfo_file = file

if swiftsourceinfo_file == None:
extension = "swiftsourceinfo"
path = swiftmodule_file.path.replace(".swiftmodule", ".swiftsourceinfo")
swiftmoudles_file_infos.append((path, extension))

contents = [
{
"type": "file",
"name": target_triple + "." + file.extension,
"external-contents": vfs_prefix + file.path,
"name": target_triple + "." + extension,
"external-contents": vfs_prefix + path,
}
for file in swiftmodules
for (path, extension) in swiftmoudles_file_infos
]

return {
Expand Down