Skip to content

Fix usage of apple_api_version #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luispadron merged 1 commit into from
Dec 18, 2023
Merged

Fix usage of apple_api_version #814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions rules/import_middleman.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Notes on Bazel 5.x.x VS 6.x.x and rules_apple rule_api_version changes:
# Notes on Bazel 5.x.x VS 6.x.x and rules_apple apple_api_version changes:
# The provider field that contains the `static_framework_file` changed to
# `imported_library` - see
# https://github.com/bazelbuild/rules_apple/commit/8d841342c238457896cd7596cc29b2d06c9a75f0
Expand Down Expand Up @@ -102,8 +102,7 @@ def _find_imports_impl(target, ctx):
imported_library_file.append(target[apple_common.Objc].imported_library)

elif AppleFrameworkImportInfo in target:
rules_apple_api_version = getattr(bundling_support, "rule_api_version", None)
use_lts_5_rules_apple_api = rules_apple_api_version == 1.0
use_lts_5_rules_apple_api = apple_api_version == "1.0"
if use_lts_5_rules_apple_api:
static_framework_file.append(target[apple_common.Objc].static_framework_file)
else:
Expand Down