Move to using write_file from Bazel Skylib
#778
Conversation
luispadron
requested review from
jerrymarino,
jszumski,
mattrobmattrob and
thiagohmcruz
luispadron
force-pushed
the
luis/use-bazel-skylib-write_file
branch
from
2efa72c to
1346660
Compare
mattrobmattrob
left a comment
mattrobmattrob
left a comment
There was a problem hiding this comment.
👏 This should probably be a major version bump since it removes a macro/rule.
Sounds good, I'll release a 3.0 bundled with the stardoc bzlmod upgrade (which also changes some api around bzl_library) and it'll be the first version released to the registry |
justinseanmartin
left a comment
justinseanmartin
left a comment
There was a problem hiding this comment.
FYI - On a quick GH search, I couldn't find any public users of this API, but there still could presumably be some private ones. I don't feel super strongly about the major version bump personally, but not opposed to it either to follow semver to the letter. I don't think this was ever intended as part of the public API surface and is easily replaceable. It might be nice if we could be more strict about the public API surface so we don't end up needing to make a breaking API change for something like this.
Makes #776 a bit easier as one less rule to document and saves some code.