Skip to content

Virtual hermetic frameworks #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerrymarino merged 3 commits into from
Jul 21, 2021
Merged

Virtual hermetic frameworks #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3396e48
Virtual hermetic frameworks
jerrymarino Jul 6, 2021
8eb6e42
Buildifier
jerrymarino Jul 21, 2021
24b928a
Make inclusion of vfs identical to previous, docs
jerrymarino Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/framework_doc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<pre>
apple_framework_packaging(<a href="#apple_framework_packaging-name">name</a>, <a href="#apple_framework_packaging-bundle_extension">bundle_extension</a>, <a href="#apple_framework_packaging-bundle_id">bundle_id</a>, <a href="#apple_framework_packaging-deps">deps</a>, <a href="#apple_framework_packaging-framework_name">framework_name</a>,
<a href="#apple_framework_packaging-minimum_os_version">minimum_os_version</a>, <a href="#apple_framework_packaging-platform_type">platform_type</a>, <a href="#apple_framework_packaging-platforms">platforms</a>, <a href="#apple_framework_packaging-skip_packaging">skip_packaging</a>,
<a href="#apple_framework_packaging-transitive_deps">transitive_deps</a>)
<a href="#apple_framework_packaging-transitive_deps">transitive_deps</a>, <a href="#apple_framework_packaging-vfs">vfs</a>)
</pre>

Packages compiled code into an Apple .framework package
Expand All @@ -27,6 +27,7 @@ Packages compiled code into an Apple .framework package
| <a id="apple_framework_packaging-platforms"></a>platforms | A dictionary of platform names to minimum deployment targets. If not given, the framework will be built for the platform it inherits from the target that uses the framework as a dependency. | <a href="https://bazel.build/docs/skylark/lib/dict.html">Dictionary: String -> String</a> | optional | {} |
| <a id="apple_framework_packaging-skip_packaging"></a>skip_packaging | Parts of the framework packaging process to be skipped. Valid values are: - "binary" - "modulemap" - "header" - "private_header" - "swiftmodule" - "swiftdoc" | List of strings | optional | [] |
| <a id="apple_framework_packaging-transitive_deps"></a>transitive_deps | Deps of the deps | <a href="https://bazel.build/docs/build-ref.html#labels">List of labels</a> | required | |
| <a id="apple_framework_packaging-vfs"></a>vfs | Additional VFS for the framework to export | <a href="https://bazel.build/docs/build-ref.html#labels">List of labels</a> | optional | [] |


<a id="#apple_framework"></a>
Expand Down
4 changes: 4 additions & 0 deletions rules/features.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
feature_names = struct(
# Virtualize means that swift,clang read from llvm's in-memory file system
virtualize_frameworks = "apple.virtualize_frameworks",
Copy link
Contributor

@congt congt Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there any reason why we treat it as a feature? Could we simply delete the old way to simplify the code?

Copy link
Contributor Author

@jerrymarino jerrymarino Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's easier to iterate on code that's behind a feautre. This and we don't want to disrupt the old code path and may roll this out as an a/b test. Probably longer term we'd want to remove the useage of frameworks altogether

Copy link
Contributor Author

@jerrymarino jerrymarino Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( that is, no remove the "frameworks" as a feature )

)
Loading