Define aliased tools as binaries #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rrbutani It looks like the failures in CI are unrelated to this change. Are these known to be flaky? |
|
@oliverlee Yup, the external tests are flaky. There were some related changes recently that I think your branch is missing but even with those changes the external tests will still fail. I wouldn't worry about it and this PR looks good to me but @siddharthab should take a look too (I'm not really an active maintainer of this repo anymore). |
|
Can you rebase your branch on the latest master? I think at least one of those failure is gone by now. But independent of the test failure, I would not wrap the aliased file in a sh_binary. If one does not exist, maybe making a small custom rule would do the job. |
Define tools as native_binary's instead of aliases to filegroups, allowing use with rules that expect `files_to_run.executable` attributes.
oliverlee
force-pushed
the
tool-binaries
branch
from
5915dca to
34939ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define tools as sh_binary's instead of aliases to filegroups, allowing use with rules that expect
files_to_run.executableattributes (e.g. https://github.com/erenon/bazel_clang_tidy).