Reduce duplication in directory delete utils #1108
Conversation
ittaiz
left a comment
ittaiz
left a comment
There was a problem hiding this comment.
Very much in favor of the PR in general. See two questions inside
| import java.nio.file.*; | ||
| import java.nio.file.attribute.BasicFileAttributes; | ||
|
|
||
| public class DeleteRecursively { |
There was a problem hiding this comment.
why not keep this implementation? Sounds better without the sort
There was a problem hiding this comment.
why not keep this implementation? Sounds better without the sort
I left the stream based version, because I felt it has less boilerplate code
There was a problem hiding this comment.
On the other hand it sorts and this one doesn't so it sounds more performant and we're already trying to optimize our perf
liucijus
force-pushed
the
clean-utils
branch
from
4c563f9 to
5fab80b
Compare
|
@liucijus if you can minimize force pushing it would really help me review the code (github has better abilities to see new changes) |
liucijus
force-pushed
the
clean-utils
branch
from
5fab80b to
d2a7379
Compare
|
Unfortunately I had to force push to not to mess on top of orginal authorship of the code. |
|
failure is due to github |
4 participants
There are multiple implementation of recursive directory deletion utils. Let's have single implementation.