Dependency checkers do not detect scala macro dependencies

[laurynaslubys]

It seems like strict/unused dependency checkers do not detect dependencies used by scala macros. The case where I ran into this is the following:

@com_wix_accord_core_2_12 uses @org_scalamacros_resetallattrs_2_12 in its invocation for com.wix.accord.dsl#validator macro. Is this is a known limitation?

[johnynek]

there are a few limitations with this. I don't think this one was noted before.

I think we should be lobbying the scalac developers to make this a supported feature, and not a hack we build with a plugin.

[arjantop]

Is this the same issue? macwire macros dependency is marked unused
https://github.com/arjantop/rules_scala_bug

[ittaiz]

Good question, don't know. Summoning @Jamie5 as our resident unused deps expert.

[Jamie5]

So the issues are at least similar in that the dependency analyzer is not working properly in both cases. In your case you are using ast mode, and hence is something we can fix (we just need to examine the original macro). I will send out a diff shortly.

(as a side note I am just some random person who knows nothing about anything)

[Jamie5]

#1008

(Note, this addresses only ast mode and not high-level mode)

[ittaiz]

Thanks! @laurynasl-wix now that I’ve merged #1008 can you check again (and turn on AST mode)?

[arjantop]

Thank you @Jamie5 (and everyone involved) for the quick fix!

[laurynaslubys]

We don't face this issue anymore either as we switched to using +1 dependency model (rather then strict), so we don't need to have the transitive dependency explicitly declared in our code. Closing the issue.