-
-
Notifications
You must be signed in to change notification settings - Fork 635
chore(toolchain): drop all but the latest 3.9 toolchain #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's toolchain configuration by removing outdated Python 3.9 versions, aligning with its End-of-Life status. This cleanup reduces maintenance overhead and ensures that only actively supported toolchains are available. Additionally, a new "Unreleased" section has been introduced in the changelog to better organize and communicate forthcoming updates. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes older Python 3.9 toolchains, keeping only the latest one, and updates the changelog accordingly. My review focuses on the correctness of the changelog update and a minor point of confusion in the toolchain definition file. The main issue is that the changelog has been updated incorrectly by adding a duplicate 'Unreleased' section, which will likely break your release tooling. I've also pointed out a confusing comment in python/versions.bzl that seems to have been added by mistake.
| ## Unreleased | ||
|
|
||
| [0.0.0]: https://github.com/bazel-contrib/rules_python/releases/tag/0.0.0 | ||
|
|
||
| {#v0-0-0-removed} | ||
| ### Removed | ||
| * (toolchain) removed all old 3.9 toolchains except for the latest version since it has been | ||
| announced as an EOL. | ||
|
|
||
| {#v0-0-0-changed} | ||
| ### Changed | ||
| * Nothing changed. | ||
|
|
||
| {#v0-0-0-fixed} | ||
| ### Fixed | ||
| * (gazelle) Remove {obj}`py_binary` targets with invalid `srcs`. This includes files | ||
| that are not generated or regular files. | ||
|
|
||
| {#v0-0-0-added} | ||
| ### Added | ||
| * Nothing added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new ## Unreleased section duplicates the structure and anchors (e.g., {#v0-0-0-removed}) from the BEGIN_UNRELEASED_TEMPLATE section located inside the HTML comment block above. This duplication will likely break the changelog generation tooling.
All new changes should be added directly into the template section. Please remove this entire block and instead:
- Add the
(toolchain)removal note to the### Removedsection inside the template (replacing* Nothing removed.). - Revert the change to the
### Fixedsection in the template, so it once again contains the(gazelle)fix that was previously there.
14e9ee8 to
196f501
Compare
Whilst at it create a new changelog section