Skip to content

Conversation

@aignas
Copy link
Collaborator

@aignas aignas commented Oct 23, 2025

Whilst at it create a new changelog section

@aignas aignas requested a review from rickeylev as a code owner October 23, 2025 02:33
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's toolchain configuration by removing outdated Python 3.9 versions, aligning with its End-of-Life status. This cleanup reduces maintenance overhead and ensures that only actively supported toolchains are available. Additionally, a new "Unreleased" section has been introduced in the changelog to better organize and communicate forthcoming updates.

Highlights

  • Toolchain Management: Obsolete Python 3.9 toolchain versions (3.9.10 through 3.9.23) have been removed from python/versions.bzl, retaining only the latest 3.9.24 version, as Python 3.9 has reached End-of-Life (EOL).
  • Changelog Update: A new "Unreleased" section has been added to CHANGELOG.md to document upcoming changes, including the toolchain removals, and existing fixes have been re-categorized within this new section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes older Python 3.9 toolchains, keeping only the latest one, and updates the changelog accordingly. My review focuses on the correctness of the changelog update and a minor point of confusion in the toolchain definition file. The main issue is that the changelog has been updated incorrectly by adding a duplicate 'Unreleased' section, which will likely break your release tooling. I've also pointed out a confusing comment in python/versions.bzl that seems to have been added by mistake.

Comment on lines +51 to +71
## Unreleased

[0.0.0]: https://github.com/bazel-contrib/rules_python/releases/tag/0.0.0

{#v0-0-0-removed}
### Removed
* (toolchain) removed all old 3.9 toolchains except for the latest version since it has been
announced as an EOL.

{#v0-0-0-changed}
### Changed
* Nothing changed.

{#v0-0-0-fixed}
### Fixed
* (gazelle) Remove {obj}`py_binary` targets with invalid `srcs`. This includes files
that are not generated or regular files.

{#v0-0-0-added}
### Added
* Nothing added.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This new ## Unreleased section duplicates the structure and anchors (e.g., {#v0-0-0-removed}) from the BEGIN_UNRELEASED_TEMPLATE section located inside the HTML comment block above. This duplication will likely break the changelog generation tooling.

All new changes should be added directly into the template section. Please remove this entire block and instead:

  1. Add the (toolchain) removal note to the ### Removed section inside the template (replacing * Nothing removed.).
  2. Revert the change to the ### Fixed section in the template, so it once again contains the (gazelle) fix that was previously there.

@aignas aignas force-pushed the chore/drop-39-versions branch from 14e9ee8 to 196f501 Compare October 30, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant