build(gazelle): Update Gazelle, to bring in bzlmod support#3060
Closed
shaldengeki wants to merge 5 commits intobazel-contrib:mainfrom
Closed
build(gazelle): Update Gazelle, to bring in bzlmod support#3060shaldengeki wants to merge 5 commits intobazel-contrib:mainfrom
shaldengeki wants to merge 5 commits intobazel-contrib:mainfrom
Conversation
Contributor
Author
|
Hmm, well, this is a bummer. Looks like newer versions of Gazelle rely on go 1.20.x: https://buildkite.com/bazel/rules-python-python/builds/12038/steps/canvas?sid=0197dcca-d714-4faa-96ff-0d4a4df34557 So this requires a bump of that. Lemme see if that's not too painful - I'm hoping not. |
Contributor
Author
|
Hmmmmmm. iiiinteresting. |
Contributor
Author
|
Ah, I guess @dougthor42 is already working on this here: #2962 |
Contributor
Author
|
Gonna close this while I figure out what to do in #3057. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades the version of Gazelle to HEAD. I need this, because I'd like to write tests in #3057 against a setup using bzlmod, but our current version doesn't support that:
(note the
MODULE.bazelin the above logs. That's the test I'm adding covering bzlmod support.)With this change, the test works: