fix: work around version parsing by only parsing if site-packages is enabled#3031
Merged
aignas merged 1 commit intobazel-contrib:mainfrom Jun 26, 2025
Conversation
rickeylev
force-pushed
the
fix.parse.version.if.site.packages.enabled
branch
from
6e000b8 to
a2d92f8
Compare
aignas
approved these changes
Jun 26, 2025
rickeylev
added a commit
that referenced
this pull request
Jun 26, 2025
…enabled (#3031) There's a bug in the version string parser that doesn't handle local identifiers correctly. Thankfully, it's only activated in the experimental code path when site packages for libraries is eanbled. Moving the logic within that block works around it. Work around for #3030 (cherry picked from commit aab2650)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug in the version string parser that doesn't handle local identifiers correctly.
Thankfully, it's only activated in the experimental code path when site packages for
libraries is eanbled. Moving the logic within that block works around it.
Work around for #3030