fix(toolchains): use posix-compatible exec -a alternative#3010
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Jun 20, 2025
Merged
fix(toolchains): use posix-compatible exec -a alternative#3010rickeylev merged 2 commits intobazel-contrib:mainfrom
rickeylev merged 2 commits intobazel-contrib:mainfrom
Conversation
rickeylev
force-pushed
the
fix.exec.a.posix
branch
from
c0305ec to
0c7811b
Compare
rickeylev
force-pushed
the
fix.exec.a.posix
branch
from
7bfee0e to
a91a86b
Compare
rickeylev
added a commit
that referenced
this pull request
Jun 20, 2025
The `exec -a` command doesn't work in dash, the default shell for Ubuntu/debian. To work around, use `sh -c`, which is posix and dash compatible. This allows changing the argv0 while invoking a different command. Also adds a test to verify the the runtime_env toolchain works with bootstrap script. Fixes #3009 (cherry picked from commit c4543cd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
exec -acommand doesn't work in dash, the default shell for Ubuntu/debian.To work around, use
sh -c, which is posix and dash compatible. This allows changingthe argv0 while invoking a different command. Also adds a test to verify the the
runtime_env toolchain works with bootstrap script.
Fixes #3009