fix: use platform_info.target_settings in toolchain aliases#3001
Merged
fix: use platform_info.target_settings in toolchain aliases#3001
Conversation
During the refactor we forgot one more place where the `flag_values` on the platform information was used. They were no longer populated and broke. The solution is to use `selects.config_setting_group` to maintain behaviour and in order to smoke test I have added a target to verify that the aliases work. Fixup to #2875 Fixes #2993
rickeylev
approved these changes
Jun 17, 2025
Collaborator
|
Ahhh, I see now. Yeah, I missed that toolchain aliases repo. We should deprecate that thing; the toolchain-based lookup replaces it. |
rickeylev
added a commit
to rickeylev/rules_python
that referenced
this pull request
Jun 17, 2025
…ntrib#3001) During the refactor we forgot one more place where the `flag_values` on the platform information was used. They were no longer populated and broke. The solution is to use `selects.config_setting_group` to maintain behaviour and in order to smoke test I have added a target to verify that the aliases work. Related to bazel-contrib#2875 Fixes bazel-contrib#2993 Co-authored-by: Richard Levasseur <richardlev@gmail.com> (cherry picked from commit 107a878)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the refactor we forgot one more place where the
flag_valuesonthe platform information was used. They were no longer populated and
broke.
The solution is to use
selects.config_setting_groupto maintainbehaviour and in order to smoke test I have added a target to verify
that the aliases work.
Related to #2875
Fixes #2993