Skip to content

refactor: Remove unused CC_TOOLCHAIN definition#2981

Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom
katre:remove-ccct
Jun 13, 2025
Merged

refactor: Remove unused CC_TOOLCHAIN definition#2981
rickeylev merged 1 commit intobazel-contrib:mainfrom
katre:remove-ccct

Conversation

@katre
Copy link
Member

@katre katre commented Jun 12, 2025

Fixes #2979.

The definition appears unused and helps advance the goal of entirely removing current_cc_toolchain: see bazelbuild/bazel#26282.

@katre katre requested review from aignas and rickeylev as code owners June 12, 2025 15:28
@katre
Copy link
Member Author

katre commented Jun 12, 2025

@rickeylev Do you know who should review this?

@rickeylev rickeylev added this pull request to the merge queue Jun 13, 2025
@rickeylev
Copy link
Collaborator

I'd be the most appropriate.

Hm, I swear when I was grepping around I saw _cc_toolchain somewhere else, too. In any case, this still valid cleanup. LGTM.

Regardless, usage of the cc toolchain should be unused. The Bazel py rules don't build a C++ artifact like the Google py rules do.

Merged via the queue into bazel-contrib:main with commit f2fa07a Jun 13, 2025
2 checks passed
@katre katre deleted the remove-ccct branch June 13, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove use of current_cc_toolchain

2 participants