refactor: Remove unused CC_TOOLCHAIN definition#2981
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Jun 13, 2025
katre:remove-ccct
Merged
refactor: Remove unused CC_TOOLCHAIN definition#2981rickeylev merged 1 commit intobazel-contrib:mainfrom katre:remove-ccct
rickeylev merged 1 commit intobazel-contrib:mainfrom
katre:remove-ccct
Conversation
Member
Author
|
@rickeylev Do you know who should review this? |
rickeylev
approved these changes
Jun 13, 2025
Collaborator
|
I'd be the most appropriate. Hm, I swear when I was grepping around I saw Regardless, usage of the cc toolchain should be unused. The Bazel py rules don't build a C++ artifact like the Google py rules do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2979.
The definition appears unused and helps advance the goal of entirely removing current_cc_toolchain: see bazelbuild/bazel#26282.