Ensure all core Python rules are loaded from defs.bzl #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates rules_python itself for bazelbuild/bazel#9006. This entails adding or updating load() statements to refer to //python:defs.bzl (not //python:python.bzl), and updating whl.py so the generated repos refer to @rules_python. Also updated the dependency on subpar for compatibility with the flag. Par files are regenerated.
gregestren
approved these changes
Aug 2, 2019
fweikert
pushed a commit
to fweikert/rules_python
that referenced
this pull request
Aug 7, 2019
) This migrates rules_python itself for bazelbuild/bazel#9006. This entails adding or updating load() statements to refer to //python:defs.bzl (not //python:python.bzl), and updating whl.py so the generated repos refer to @rules_python. Also updated the dependency on subpar for compatibility with the flag. Par files are regenerated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates rules_python itself for bazelbuild/bazel#9006. This entails
adding or updating load() statements to refer to //python:defs.bzl (not
//python:python.bzl), and updating whl.py so the generated repos refer to
@rules_python. Also updated the dependency on subpar for compatibility with
the flag. Par files are regenerated.