fix issue where rules_perl could not used for cross compilation #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the perl toolchain and specifying a platform on the bazel command line (e.g. --platforms=:android), the command would fail as bazel required a perl toolchain that is "target compatible" with the ":android" platform. Unlike a C++ toolchain, the perl toolchain is compatible with any target platform.
Merged
|
@PiotrSikora @skeletonkey Would it be possible for one of you guys to review this PR please? |
|
@jheaff1 I will be able to take a look at this this weekend (Monday at the latest). Sorry for the delay - end of year has been a little crazy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the perl toolchain and specifying a platform on the bazel
command line (e.g. --platforms=:android), the command would fail as
bazel required a perl toolchain that is "target compatible" with the
":android" platform. Unlike a C++ toolchain, the perl toolchain is
compatible with any target platform therefore no
target_compatible_withshould be specified