Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules_nodejs CI is broken with Bazel@Head #3465

Closed
mai93 opened this issue May 24, 2022 · 0 comments · Fixed by #3466
Closed

rules_nodejs CI is broken with Bazel@Head #3465

mai93 opened this issue May 24, 2022 · 0 comments · Fixed by #3466

Comments

@mai93
Copy link

mai93 commented May 24, 2022

managed_directories was deprecated in this commit and this is causing rules_nodejs CI to fail when tested with Bazel@Head (error). You can follow the instructions in bazelbuild/bazel#15463 for more information on how to migrate away from using managed_directories.
alexeagle added a commit that referenced this issue May 25, 2022
@alexeagle
chore: remove usage of managed_directories
8966685 
We discouraged users from using this as of rnj 5.0, and now Bazel is removing the feature.

Fixes #3465
@alexeagle alexeagle mentioned this issue May 25, 2022
Merged
gregmagolan pushed a commit that referenced this issue Jun 9, 2022
@alexeagle
chore: remove usage of managed_directories (#3466)
f96cfde 
* chore: remove usage of managed_directories

We discouraged users from using this as of rnj 5.0, and now Bazel is removing the feature.

Fixes #3465

* Also remove symlink_node_modules = True usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove usage of managed_directories bazel-contrib/rules_nodejs
1 participant
@mai93