Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in empty .go file filtering for nogo #3832

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Fix regression in empty .go file filtering for nogo #3832

merged 2 commits into from
Jan 18, 2024

Commits on Jan 18, 2024

  1. Fix regression in empty .go file filtering for nogo 

    6236dd8 regressed the nogo exclusion
logic for the empty `.go` file generated for targets that otherwise
don't contain any `.go` files. The test had been silently disabled a
while ago when the name pattern for the empty file was changed.

This is fixed by reintroducing the exclusion logic and making the test
more strict.
    @fmeum
    fmeum committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2ea6f31 View commit details
    Browse the repository at this point in the history

  2. Update go/tools/builders/compilepkg.go 

    Co-authored-by: Tyler French <66684063+tyler-french@users.noreply.github.com>
    @fmeum @tyler-french
    fmeum and tyler-french authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    987a3a3 View commit details
    Browse the repository at this point in the history