Support generated embedsrcs #3096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Koch <chrisko@google.com>
This was referenced Mar 28, 2022
|
Can you add tests to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like for srcs, rules_go should support generated embedsrcs.
I'm currently running into a situation in which I've generated embed files, but I cannot pass them into
go.new_library(because those get ignored) or into the attrs forlibrary_to_source-- becauselibrary_to_sourceattr.embedsrcs is expected to be of type list of Target, and when you generate them, you generate a list of File. There isn't really a way to generate the targets, which is whysrcsdoes the same thing of allowinggo.new_libraryto specify a list of File and library_to_source attrs to specify targets and combines the two. This extends that toembedsrcs.