Minor feature: allowing patching the toolchain #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a patch and patch_strip attribute to the go_download_sdk rule. This is only available when calling this rule directly, and not when using the go_register_toolchains wrapper. This allows for the applicable of a single patch to the toolchain, using the built-in repository_ctx patch method.
amscanne
force-pushed
the
go_sdk_patch
branch
from
9bfe156 to
2980f2d
Compare
linzhp
reviewed
Mar 15, 2022
Comment on lines
+126
to
+127
| "patch": attr.label(default = None), | ||
| "patch_strip": attr.int(default = 0), |
There was a problem hiding this comment.
Let's follow the convention of go_repository rule:
- Having
patchesto be a label_list, so it can take multiple patches - Having
patch_argsto be string_list, and defaults to["-p0"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds a trivial feature to go_download_sdk that allows for applying a single patch via the repository_ctx patch method. This is only exposed via the go_download_sdk rule, and not any wrapper rules.
Which issues(s) does this PR fix?
As a trivial feature, there is no issue.