Skip to content

Conversation

@dcarp
Copy link
Collaborator

@dcarp dcarp commented Oct 17, 2025

Fixes #112

@dcarp dcarp requested a review from Copilot October 17, 2025 21:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reduces the action sandbox size for d_library targets by excluding unnecessary library artifacts from the compilation action inputs (Fixes #112).

  • Factor out inputs depset to a local variable and pass it into ctx.actions.run
  • Conditionally exclude d and C libraries from inputs when target_type == TARGET_TYPE.LIBRARY

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dcarp dcarp force-pushed the fix/excesive-lib-inputs branch from c01a257 to 6ba2395 Compare October 17, 2025 21:49
@dcarp dcarp requested a review from Copilot October 17, 2025 21:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dcarp dcarp merged commit 785683b into bazel-contrib:main Oct 19, 2025
11 checks passed
@dcarp dcarp deleted the fix/excesive-lib-inputs branch October 19, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Excessive inputs: why libs are inputs for another libs?

1 participant