Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic CI testing for clang #143

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Add basic CI testing for clang #143

merged 4 commits into from
Aug 9, 2023

Conversation

cloudhan
Copy link
Collaborator

@cloudhan cloudhan commented Aug 9, 2023

No description provided.

jsharpe
jsharpe approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@jsharpe jsharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it'd be good at some point to get an example of how to use this with the grailbio/bazel-toolchain repo for a hermetic clang install; I think when I tried this previously there were some issues with paths

@cloudhan cloudhan merged commit 587955a into main Aug 9, 2023
12 checks passed
@cloudhan cloudhan deleted the cloudhan/clang-ci branch August 9, 2023 15:47
@cloudhan cloudhan mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsharpe jsharpe jsharpe approved these changes

@ryanleary ryanleary Awaiting requested review from ryanleary ryanleary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudhan @jsharpe