Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase release archive download exponential delay #171

Closed
wants to merge 1 commit into from

Conversation

kormide
Copy link
Collaborator

@kormide kormide commented Oct 10, 2024

To account for release archives that get uploaded shortly after the release is published.

Closes #140.

fyi @ouillie

@kormide kormide requested a review from cgrindel October 10, 2024 23:14
@ouillie
Copy link
Contributor

ouillie commented Oct 10, 2024

Thanks for taking a look! Should've been more communicative about #170 🤷 I don't have much experience with JS in general and I don't have a strong opinion on whether a large timeout or the default timeout resetting between retries makes more sense. I opted for the latter because it seemed less intrusive, but this looks just as good to me, FWIW.

@kormide
Copy link
Collaborator Author

kormide commented Oct 10, 2024

Duplicate of #170.

@kormide kormide closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we stop requiring release archives to be uploaded as part of publishing the release
2 participants