Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(release): switch release integrity to be dynamic #854

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

alexeagle
Copy link
Collaborator

This matches rules_py as documented by
https://blog.aspect.build/releasing-bazel-rulesets-rust

It has the benefit that developers no longer get yelled at to vendor some updated integrity hashes into bazel-lib every time they touch the Go sources.


Changes are visible to end-users: no

Test plan

Validated on https://github.com/alexeagle/bazel-lib/releases
downloading the latest release and cracking it open looks right.

This matches rules_py as documented by
https://blog.aspect.build/releasing-bazel-rulesets-rust

It has the benefit that developers no longer get yelled at to vendor some updated integrity hashes into bazel-lib every time they touch the Go sources.
.bazelrc Show resolved Hide resolved
Copy link

aspect-workflows bot commented May 23, 2024

Test

4 test targets passed

Targets
//lib/tests/copy_to_directory_bin_action:test [k8-fastbuild]            29ms
//lib/tests/jq:check_stamped [k8-fastbuild]                             321ms
//lib/tests/run_binary_expansions:expansions_golden_test [k8-fastbuild] 225ms
//lib/tests/yq:check_stamped [k8-fastbuild]                             379ms

Total test execution time was 954ms. 211 tests (98.1%) were fully cached saving 43s.


Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 583ms.


Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 423ms.


Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Buildifier      Format      Gazelle

Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧙

We now only use --compilation_mode=opt when cutting a release
@alexeagle alexeagle merged commit 4ad02b7 into main May 23, 2024
35 checks passed
@alexeagle alexeagle deleted the fixci branch May 23, 2024 23:08
alexeagle added a commit that referenced this pull request May 23, 2024
alexeagle added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants