Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presets: remove eternal test_timeout_filtering #758

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

alexeagle
Copy link
Collaborator

In practice we've disabled this setting at some clients, because there's not a surrounding workflow to find these targets are being silently dropped from CI, nor run them on another schedule.

We can re-introduce something better when we add Test Selection to Aspect Workflows.


Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

For changes visible to end-users

  • Suggested release notes are provided below:

We no longer recommend filtering test targets by timeout on CI for all cases. Some organizations may still want to restore this setting locally as a matter of policy, but you need to do something with the filtered test targets to keep them green.

In practice we've disabled this setting at some clients, because there's not a surrounding workflow to find these targets are being silently dropped from CI, nor run them on another schedule.

We can re-introduce something better when we add Test Selection to Aspect Workflows.
@gregmagolan gregmagolan merged commit 6d3195f into main Feb 16, 2024
70 checks passed
@gregmagolan gregmagolan deleted the alexeagle-patch-2 branch February 16, 2024 21:56
gregmagolan pushed a commit that referenced this pull request Mar 27, 2024
In practice we've disabled this setting at some clients, because there's not a surrounding workflow to find these targets are being silently dropped from CI, nor run them on another schedule.

We can re-introduce something better when we add Test Selection to Aspect Workflows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants