Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support stamp substituions #435

Merged
merged 5 commits into from
May 16, 2023
Merged

feat: support stamp substituions #435

merged 5 commits into from
May 16, 2023

Conversation

thesayyn
Copy link
Collaborator

Type of change

Test plan

  • New test cases added

@thesayyn thesayyn requested a review from gregmagolan May 16, 2023 19:12
@thesayyn
Copy link
Collaborator Author

made sure that failures are isolated to missing toolchain hashes/artifacts for expand_template.

@gregmagolan
Copy link
Collaborator

Looks great. Lets split this up into two PRs for landing.

  1. Bring in the toolchain and the golang binaries but don't change the existing expand_template rule

We'll then cut a patch release so the binary is published

  1. Update the rule & reference the golang artifacts from the previous release

tools/expand_template/main.go Outdated Show resolved Hide resolved
tools/expand_template/main.go Outdated Show resolved Hide resolved
tools/expand_template/main.go Outdated Show resolved Hide resolved
tools/expand_template/main.go Outdated Show resolved Hide resolved
tools/expand_template/main.go Outdated Show resolved Hide resolved
tools/expand_template/main.go Outdated Show resolved Hide resolved
tools/expand_template/main.go Outdated Show resolved Hide resolved
tools/expand_template/main.go Outdated Show resolved Hide resolved
@gregmagolan
Copy link
Collaborator

Lets create a new expand_template.bzl load point for this rule with the PR and a new docs file for that so it shows up separately in the docsite. The expand_make_vars load point can stick around for now for backward compat with a # TODO(2.0): remove comment on it.

@thesayyn thesayyn dismissed f0rmiga’s stale review May 16, 2023 23:11

addressed valid concerns, and we have landed the go binary already.

@thesayyn
Copy link
Collaborator Author

Lets create a new expand_template.bzl load point for this rule with the PR and a new docs file for that so it shows up separately in the docsite. The expand_make_vars load point can stick around for now for backward compat with a # TODO(2.0): remove comment on it.

done

@thesayyn thesayyn enabled auto-merge (squash) May 16, 2023 23:11
@thesayyn thesayyn merged commit 6af964f into main May 16, 2023
Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants