feat: add runfiles helpers needed for rules_js #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvarier
reviewed
Nov 10, 2021
lib/utils.bzl
Outdated
| @@ -7,3 +7,62 @@ glob_directories = utils.glob_directories | |||
| path_to_workspace_root = utils.path_to_workspace_root | |||
| propagate_well_known_tags = utils.propagate_well_known_tags | |||
| to_label = utils.to_label | |||
|
|
|||
| BATCH_RLOCATION_FUNCTION = r""" | |||
There was a problem hiding this comment.
Some suggestions:
- If I'm not mistaken, this was ported over from https://github.com/bazelbuild/rules_nodejs/blob/aa09b5796faaf2470b84246a8f00e6e27181c63b/internal/common/windows_utils.bzl. From what I understand, this is only used for building on Windows, do you think it would be better to put this into a file called
windows_utils.bzl? - I don't see that this is being used anywhere currently; if it is only intended to be exposed for client consumption would it be worth adding unit tests for?
There was a problem hiding this comment.
Yes, that's where it came from. Making a windows specific file SGTM, we'll have other helpers to go there.
(I'm assuming we'll have to refactor the organization here a bit as we add more code)
It will only be used in downstream rules (rules_js to start). Testing is hard because we don't have windows executors on GitHub actions yet.
lib/utils.bzl
Outdated
| :: End of rlocation | ||
| """ | ||
|
|
||
| BASH_RLOCATION_FUNCTION = r""" |
There was a problem hiding this comment.
Same suggestions as above, but additionally:
- Since there's not much commentary going on here, it's a little hard to understand what it's doing or why it's needed.
- As this was copy pasted, would you be able to link to the source?
There was a problem hiding this comment.
good suggestions thanks :)
lib/private/paths.bzl
Outdated
| @@ -42,6 +42,28 @@ def _relative_file(to_file, frm_file): | |||
| ) | |||
| ) | |||
|
|
|||
| # | |||
| # | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.