feat: add out_dirs to run_binary rule and deprecate output_dir #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
approved these changes
Jun 16, 2022
gregmagolan
force-pushed
the
out_dirs
branch
2 times, most recently
from
bf5bc98
to
2c06ed3
Compare
alexeagle
approved these changes
Jun 16, 2022
lib/private/expand_make_vars.bzl
Outdated
| attribute_name: name of the attribute containing the expression | ||
|
|
||
| Returns: | ||
| `s` with the variables expanded | ||
| """ | ||
| rule_dir = [f for f in [ | ||
| rule_dir = "/".join([f for f in [ |
There was a problem hiding this comment.
nit: same _join helper we have everywhere...
There was a problem hiding this comment.
right; I should remember to use @bazel_skylib//lib:paths.bzl join function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding change in rules_js is aspect-build/rules_js#216