Skip to content

refactor: remove yq toolchain #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025
Merged

refactor: remove yq toolchain #1135

merged 1 commit into from
Jul 27, 2025

Conversation

alexeagle
Copy link
Collaborator

BREAKING CHANGE:
The yq toolchain type is no longer in bazel-lib. Use the symbol @yq.bzl//yq/toolchain:type in case you were registering a custom YQ toolchain.

BREAKING CHANGE:
The yq toolchain type is no longer in bazel-lib. Use the symbol @yq.bzl//yq/toolchain:type
in case you were registering a custom YQ toolchain.
@alexeagle alexeagle requested review from jbedard and fmeum July 26, 2025 20:33
@fmeum
Copy link
Member

fmeum commented Jul 26, 2025

Does the new toolchain type exist yet? I only see references to bazel-lib in yq.bzl. Otherwise this LGTM.

@jbedard
Copy link
Collaborator

jbedard commented Jul 27, 2025

@alexeagle shouldn't we move the implementation to yq.bzl first? I guess when this is merging to a 3.0 branch it doesn't really matter what order we do it, but we'll have to do it...

@alexeagle
Copy link
Collaborator Author

@jbedard the implementation moved two months ago to https://github.com/bazel-contrib/yq.bzl
bazel-contrib/yq.bzl#16 has the port of the code removed in this PR and I just released as v0.2.0

@alexeagle alexeagle merged commit a95293f into 3.0 Jul 27, 2025
30 checks passed
@alexeagle alexeagle deleted the rm_yq_toolchain branch July 27, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants