Revert "Allow MatchAttrs to be slices (#730)" #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8be1e16.
linzhp
added a commit
to linzhp/bazel-gazelle
that referenced
this pull request
Mar 27, 2020
…azel-contrib#743)" This reverts commit c7d8513.
Merged
eugen-kleiner-mesh
pushed a commit
to eugen-kleiner-mesh/bazel-gazelle
that referenced
this pull request
Apr 14, 2020
eugen-kleiner-mesh
pushed a commit
to eugen-kleiner-mesh/bazel-gazelle
that referenced
this pull request
Apr 14, 2020
When bazel-contrib#730 was opened, it was based on top of bazel-contrib#720. So the tests were passing on bazel-contrib#730. However, bazel-contrib#720 was reverted on master before bazel-contrib#730 was merged. When merging bazel-contrib#730 onto master, its tests started to fail. This PR reverted bazel-contrib#743 and fixed the failing tests Fixed bazel-contrib#742
opendoor-dev
pushed a commit
to opendoor-labs/bazel-gazelle
that referenced
this pull request
Apr 16, 2020
opendoor-dev
pushed a commit
to opendoor-labs/bazel-gazelle
that referenced
this pull request
Apr 16, 2020
When bazel-contrib#730 was opened, it was based on top of bazel-contrib#720. So the tests were passing on bazel-contrib#730. However, bazel-contrib#720 was reverted on master before bazel-contrib#730 was merged. When merging bazel-contrib#730 onto master, its tests started to fail. This PR reverted bazel-contrib#743 and fixed the failing tests Fixed bazel-contrib#742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8be1e16.
Updates #742