-
Notifications
You must be signed in to change notification settings - Fork 72
Stateless adapters #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Stateless adapters #536
Conversation
Codecov ReportAttention: Patch coverage is
|
I agree that NNPE is a better fit for an augmentation than for a transform. Moving it as part of this PR (with a deprecation for the transform) sounds sensible to me. |
Agree, that should fit the use case perfectly well. Could you provide a first outline of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else besides the open NNPE
stuff looks uncritical to me. Leaving a reminder for us to shift the NNPE
tests once the augmentation
is implemented.
I like the changes overall, I'm currently removing the The signature of |
Good spot! Let's introduce them as they are described in the transform.
…On Sun, Jul 13, 2025, 11:04 AM Valentin Pratz ***@***.***> wrote:
*vpratz* left a comment (bayesflow-org/bayesflow#536)
<#536 (comment)>
I like the changes overall, I'm currently removing the .standardize()
calls from the experimental notebooks and will push the changes when I'm
done.
The signature of Adapter.standardize() is now a bit awkward in my
opinion, as mean and std are required, but are not listed in neither
signature nor docstring. They are only passed via kwargs. Do we want to
change this, @stefanradev93 <https://github.com/stefanradev93>?
—
Reply to this email directly, view it on GitHub
<#536 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFKWAGIIHWKO72L2CKVEFCT3IIOJJAVCNFSM6AAAAACBJ22KDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANRWG4ZTSNJTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This PR implements the transition towards stateless adapters, as announced in v2.0.4. In particular, it:
stage
argument from data sets and all data set builders.stage
argument from theAdapter
and all callers.standardize
transform, as the functionality is now superseded by theStandardize
layers in approximators. The remainingstandardize
transform should now be used only with fixed means / stds.stage
argument from NNPE transform. @elseml / @vpratz / @paul-buerkner This is actually a problem for the 1% of the use cases, as we don't want the noise during inference. As I thought about it, NNPE actually fits the philosophy of anaugmentation
(introduced in 2.0.3) rather than a transform (i.e., something strictly needed only during training). Thus, my proposed solution is to introduce anaugmentations
module and start collecting these transforms there (more to come). Let me know what you think.