Skip to content

Conversation

levolz
Copy link
Contributor

@levolz levolz commented Sep 13, 2023

qol change to allow to change label names if wanting something other than "ground truth" / "estimated"

stefanradev93 and others added 2 commits September 11, 2023 22:53
Add summary_dim attribute to transformers
qol change to allow to change label names if wanting something other than "ground truth" / "estimated"
@levolz levolz changed the title set_label names in plot_recovery() set label names in plot_recovery() Sep 13, 2023
@stefanradev93
Copy link
Contributor

Pls add new arguments in the docstring of the function too.

@stefanradev93
Copy link
Contributor

Pls also pull requests for Development, no direct pulls to master.

@levolz levolz changed the base branch from master to Development September 13, 2023 21:16
@levolz
Copy link
Contributor Author

levolz commented Sep 13, 2023

changed now - re: docstrings, n_col & n_row are not documented yet

@stefanradev93
Copy link
Contributor

Nice. 10x, need to document those too.

@levolz
Copy link
Contributor Author

levolz commented Sep 13, 2023

Wasn't sure about style, though - instead of

xlabel :
XXX
ylabel :
YYY

you could (for brevity) do

xlabel, ylabel :
XXX, YYY

@stefanradev93
Copy link
Contributor

As per convention, each arg gets its own line with type, default and a new line for description (see existing, looks nice when rendered).

@stefanradev93 stefanradev93 merged commit c76304a into bayesflow-org:Development Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants