Fixing issue with DELETE and PUT METHOD were working without any params.id #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #144
As issue mentioned from the DELETE method you were able to delete entire collection data just by skipping the OBJECT ID in the URL
Fix it in both handlers PUT and DELETE. Now for PUT and DELETE request.params.id is mandatory if not it will throw 400 [bad request]
However for development purpose and any other such reasons I have kept a parameter in
defaults.isSecureDelete=truewhich can be overridden at the time of the model creation.