Skip to content

Commit

Permalink
Fix JSHint warnings in javascript files
Browse files Browse the repository at this point in the history
  • Loading branch information
@saivann
saivann committed Aug 21, 2015
1 parent 4b950cf commit d1efe4d
Show file tree
Hide file tree
Showing 5 changed files with 80 additions and 82 deletions.
34 changes: 17 additions & 17 deletions js/base.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// This file should be used only for javascript code
// necessary for all pages to work properly.

"use strict"
"use strict";

function addEvent(a, b, c) {
// Attach event to a DOM node.
Expand All @@ -21,7 +21,7 @@ function removeEvent(a, b, c) {
function cancelEvent(e) {
// Cancel current event.
// Ex. cancelEvent(event);
if (!e) var e = window.event;
e = e || window.event;
(e.preventDefault) ? e.preventDefault(): e.returnValue = false;
}

Expand All @@ -33,7 +33,7 @@ function getEvent(e, a) {
case 'type':
return e.type;
case 'target':
return (e.target && e.target.nodeType == 3) ? e.target.parentNode : (e.target) ? e.target : e.srcElement;
return (e.target && e.target.nodeType === 3) ? e.target.parentNode : (e.target) ? e.target : e.srcElement;
}
}

Expand All @@ -50,7 +50,7 @@ function addClass(node, data) {
// Add class to node.
var cl = node.className.split(' ');
for (var i = 0, n = cl.length; i < n; i++) {
if (cl[i] == data) return;
if (cl[i] === data) return;
}
cl.push(data);
node.className = cl.join(' ');
Expand All @@ -61,7 +61,7 @@ function removeClass(node, data) {
var ocl = node.className.split(' ');
var ncl = [];
for (var i = 0, n = ocl.length; i < n; i++) {
if (ocl[i] != data) ncl.push(ocl[i]);
if (ocl[i] !== data) ncl.push(ocl[i]);
}
node.className = ncl.join(' ');
}
Expand All @@ -84,7 +84,7 @@ function fallbackSVG() {
// Replace all images extensions from .svg to .png if browser doesn't support SVG files.
if (supportsSVG()) return;
for (var i = 0, nd = document.getElementsByTagName('*'), n = nd.length; i < n; i++) {
if (nd[i].nodeName == 'IMG' && /.*\.svg$/.test(nd[i].src)) nd[i].src = nd[i].src.slice(0, -3) + 'png';
if (nd[i].nodeName === 'IMG' && /.*\.svg$/.test(nd[i].src)) nd[i].src = nd[i].src.slice(0, -3) + 'png';
if (/\.svg/.test(getStyle(nd[i], 'background-image'))) nd[i].style.backgroundImage = getStyle(nd[i], 'background-image').replace('.svg', '.png');
if (/\.svg/.test(getStyle(nd[i], 'background'))) nd[i].style.background = getStyle(nd[i], 'background').replace('.svg', '.png');
}
Expand All @@ -105,7 +105,7 @@ function onTouchClick(e, callback, callbackClick) {
// Cancel click events on different targets within timeframe.
// This avoids accidental clicks when the page is scrolled or updated due to the 300ms click event delay on mobiles.
removeEvent(document.body, 'click', wrongClickListener);
if (!clickReady() && getEvent(e, 'target') != t) cancelEvent(e);
if (!clickReady() && getEvent(e, 'target') !== t) cancelEvent(e);
},
setClickTimeout = function() {
// Update timeout during which click events will be blocked.
Expand Down Expand Up @@ -146,7 +146,7 @@ function mobileMenuShow(e) {
var show = function() {
var mm = document.getElementById('menusimple');
var ml = document.getElementById('langselect');
mm.style.display = ml.style.display = (mm.style.display == 'block') ? '' : 'block';
mm.style.display = ml.style.display = (mm.style.display === 'block') ? '' : 'block';
addClass(mm, 'menutap');
cancelEvent(e);
};
Expand All @@ -158,32 +158,32 @@ function mobileMenuHover(e) {
var t = getEvent(e, 'target'),
fn = (t.parentNode.className.indexOf('hover') === -1) ? addClass : removeClass,
initHover = function() {
if (t.nodeName != 'A') return;
if (fn == removeClass && !hasSubItems(t)) return;
if (t.nodeName !== 'A') return;
if (fn === removeClass && !hasSubItems(t)) return;
var p = t;
while (p.parentNode.nodeName == 'UL' || p.parentNode.nodeName == 'LI') p = p.parentNode;
while (p.parentNode.nodeName === 'UL' || p.parentNode.nodeName === 'LI') p = p.parentNode;
for (var i = 0, nds = p.getElementsByTagName('LI'), n = nds.length; i < n; i++) {
if (nds[i] == t.parentNode) continue;
if (nds[i] === t.parentNode) continue;
removeClass(nds[i], 'active');
if (hasSubItems(nds[i])) continue;
removeClass(nds[i], 'hover');
}
while (t != p) {
if (t.nodeName == 'LI') {
while (t !== p) {
if (t.nodeName === 'LI') {
fn(t, 'hover');
fn(t, 'active');
}
t = t.parentNode;
}
},
hasSubItems = function(t) {
while (t.nodeName != 'LI') t = t.parentNode;
while (t.nodeName !== 'LI') t = t.parentNode;
return (t.getElementsByTagName('UL').length > 0);
},
// Prevent clicks on parent element links in the menu.
filterClick = function(e) {
var t = getEvent(e, 'target');
if (t.nodeName != 'A') return;
if (t.nodeName !== 'A') return;
if (hasSubItems(t)) cancelEvent(e);
};
onTouchClick(e, initHover, filterClick);
Expand All @@ -198,7 +198,7 @@ function addAnchorLinks() {
}
for (var i = 0, n = nodes.length; i < n; i++) {
if (!nodes[i].id) continue;
if (nodes[i].getElementsByTagName('A').length > 0 && nodes[i].getElementsByTagName('A')[0].innerHTML == '') return;
if (nodes[i].getElementsByTagName('A').length > 0 && nodes[i].getElementsByTagName('A')[0].innerHTML === '') return;
addClass(nodes[i], 'anchorAf');
var anc = document.createElement('A');
anc.href = '#' + nodes[i].id;
Expand Down
7 changes: 3 additions & 4 deletions js/devsearch.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Nested loops below:

{% endcomment %}

"use strict"
"use strict";

var search_data = [
{% for list in site.devsearches %}{% for item in list %}
Expand All @@ -29,8 +29,7 @@ var search_data = [
label: "{{term[0]}}",
uri: "{{term[1]}}",
category: "{{category_name}}"
}
{% endfor %}{% unless forloop.last %},{% endunless %}{% endfor %}{% endif %}{% endfor %}{% unless forloop.last %},{% endunless %}{% endfor %}
}{% endfor %}{% unless forloop.last %},{% endunless %}{% endfor %}{% endif %}{% endfor %}{% unless forloop.last %},{% endunless %}{% endfor %}
];


Expand All @@ -48,7 +47,7 @@ $.widget("custom.catcomplete", $.ui.autocomplete, {
currentCategory = "";
$.each(items, function(index, item) {
var li;
if (item.category != currentCategory) {
if (item.category !== currentCategory) {
ul.append("<li class='ui-autocomplete-category'>" + item.category + "</li>");
currentCategory = item.category;
}
Expand Down
4 changes: 2 additions & 2 deletions js/events.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
layout: null
---

"use strict"
"use strict";

var zoom = 2;
var minzoom = 1;
if (isMobile()) var zoom = minzoom = 0;
if (isMobile()) zoom = minzoom = 0;
var map = L.map('eventmap', {
'zoom': zoom,
'minZoom': minzoom,
Expand Down
35 changes: 16 additions & 19 deletions js/ie.js
View file
Original file line number Diff line number Diff line change
@@ -1,46 +1,43 @@
// This file is licensed under the MIT License (MIT) available on
// http://opensource.org/licenses/MIT.

"use strict"
"use strict";

function pngfix() {
//Allows IE6 to render transparent png
var arVersion = navigator.appVersion.split("MSIE")
var version = parseFloat(arVersion[1])
var arVersion = navigator.appVersion.split("MSIE");
var version = parseFloat(arVersion[1]);
if ((version >= 5.5) && (document.body.filters))
{
for (var i = 0; i < document.images.length; i++)
{
var img = document.images[i]
var imgName = img.src.toUpperCase()
if (imgName.substring(imgName.length - 3, imgName.length) == "PNG")
var img = document.images[i];
var imgName = img.src.toUpperCase();
if (imgName.substring(imgName.length - 3, imgName.length) === "PNG")
{
//Workaround to skip github icons
if (img.src.indexOf('gravatar.com') !== -1) continue;
var imgID = (img.id) ? "id='" + img.id + "' " : ""
var imgClass = (img.className) ? "class='" + img.className + " ieimg' " : "class='ieimg' "
var imgTitle = (img.title) ? "title='" + img.title + "' " : "title='" + img.alt + "' "
var imgStyle = "display:inline-block;" + img.style.cssText
var imgID = (img.id) ? "id='" + img.id + "' " : "";
var imgClass = (img.className) ? "class='" + img.className + " ieimg' " : "class='ieimg' ";
var imgTitle = (img.title) ? "title='" + img.title + "' " : "title='" + img.alt + "' ";
var imgStyle = "display:inline-block;" + img.style.cssText;
var imgWidth = img.width;
var imgHeight = img.height;
//Workaround for hidden img to prevent 0px width and height
if (img.src.indexOf('/img/clients/') !== -1) {
imgWidth = '72';
imgHeight = '72';
}
if (img.align == "left") imgStyle = "float:left;" + imgStyle
if (img.align == "right") imgStyle = "float:right;" + imgStyle
if (img.parentElement.href) imgStyle = "cursor:hand;" + imgStyle
var strNewHTML = "<span " + imgID + imgClass + imgTitle + " style=\"" + "width:" + imgWidth + "px; height:" + imgHeight + "px;" + imgStyle + ";" + "filter:progid:DXImageTransform.Microsoft.AlphaImageLoader" + "(src=\'" + img.src + "\', sizingMethod='scale');\"></span>"
img.outerHTML = strNewHTML
i = i - 1
if (img.align === "left") imgStyle = "float:left;" + imgStyle;
if (img.align === "right") imgStyle = "float:right;" + imgStyle;
if (img.parentElement.href) imgStyle = "cursor:hand;" + imgStyle;
var strNewHTML = "<span " + imgID + imgClass + imgTitle + " style=\"" + "width:" + imgWidth + "px; height:" + imgHeight + "px;" + imgStyle + ";" + "filter:progid:DXImageTransform.Microsoft.AlphaImageLoader" + "(src=\'" + img.src + "\', sizingMethod='scale');\"></span>";
img.outerHTML = strNewHTML;
i = i - 1;
}
}
}
}

//Let other scripts know browser is IE6-7
var legacyIE = true;

//Render all transparent pngs
window.onload = pngfix;
Loading

0 comments on commit d1efe4d

Please sign in to comment.