Skip to content

Conversation

@jolinjolin
Copy link

@jolinjolin jolinjolin commented Dec 18, 2024

This is associated with issue #21

Major Changes

Add get_all_channels_status to CyclerInterface and extend messages.py
Update test_cycler_interface.py and README.md

Tests

All tests passed. cycler_interface.py and messages.py achieve 69% and 95% coverage respectively.
Screenshot 2025-01-02 123857
Screenshot 2025-01-02 123938

Signed-off-by: Jolin Xia jolin.xia1@gmail.com

Signed-off-by: Jolin Xia <jolin.xia1@gmail.com>
Signed-off-by: Jolin Xia jolin.xia1@gmail.com

Signed-off-by: Jolin Xia <jolin.xia1@gmail.com>
Signed-off-by: Jolin Xia jolin.xia1@gmail.com

Signed-off-by: Jolin Xia <jolin.xia1@gmail.com>
Signed-off-by: Jolin Xia jolin.xia1@gmail.com

Signed-off-by: Jolin Xia <jolin.xia1@gmail.com>
@jolinjolin jolinjolin force-pushed the reading-all-channels-info-feature branch from 40c5bf9 to d62089a Compare December 18, 2024 18:08
Signed-off-by: Jolin Xia <jolin.xia1@gmail.com>
@SyXuan
Copy link
Contributor

SyXuan commented Dec 23, 2024

Everything looks great, and the overall performance has improved significantly!

Could you please implement read_channel_status from channels_interface into cycler_interface?

The purpose of cycler_interface is to allow users to read all the information from the cycler, while channel_interface is more focused on reading channel-specific information after detailed configuration.

If possible, I suggest adding a read_all_channels_status method to cycler_interface and merging channel_interface and channels_interface, as they seem to have many similarities.

@jolinjolin
Copy link
Author

Everything looks great, and the overall performance has improved significantly!

Could you please implement read_channel_status from channels_interface into cycler_interface?

The purpose of cycler_interface is to allow users to read all the information from the cycler, while channel_interface is more focused on reading channel-specific information after detailed configuration.

If possible, I suggest adding a read_all_channels_status method to cycler_interface and merging channel_interface and channels_interface, as they seem to have many similarities.

Sure. I'll work it after the holiday break.

Signed-off-by: Jolin Xia <jolin.xia1@gmail.com>
Signed-off-by: Jolin Xia <jolin.xia1@gmail.com>
Signed-off-by: Jolin Xia <jolin.xia1@gmail.com>
@jolinjolin
Copy link
Author

Hi @SyXuan the refactoring is complete and ready for review. Please let me know if further adjustments are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants