Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"types" in package.json points to wrong file #113

Closed
jd1378 opened this issue May 14, 2022 · 2 comments · Fixed by #114
Closed

"types" in package.json points to wrong file #113

jd1378 opened this issue May 14, 2022 · 2 comments · Fixed by #114
Assignees
@sgtsquiggs
Labels
bug Something isn't working released

Comments

@jd1378
Copy link
Contributor

jd1378 commented May 14, 2022

it currently points to lib/types/Adhan.d.ts while it should point to lib/types/src/Adhan.d.ts
@sgtsquiggs
Copy link
Contributor

Will look in to this today.

@sgtsquiggs sgtsquiggs added the bug Something isn't working label May 14, 2022
@sgtsquiggs sgtsquiggs self-assigned this May 14, 2022
sgtsquiggs added a commit that referenced this issue May 14, 2022
@sgtsquiggs
fix(types): fix incorrect types generation
e35c52b 
fix #113
sgtsquiggs added a commit that referenced this issue May 14, 2022
@sgtsquiggs
fix(types): fix incorrect types generation
f5613da 
fix #113
@sgtsquiggs sgtsquiggs linked a pull request May 14, 2022 that will close this issue
Fix incorrect types generation #114
Merged
@sgtsquiggs sgtsquiggs mentioned this issue May 14, 2022
Merged
github-actions bot pushed a commit that referenced this issue May 14, 2022
@semantic-release-bot
chore(release): 4.4.3 [skip ci]
b6e5ddf 
## [4.4.3](v4.4.2...v4.4.3) (2022-05-14)

### Bug Fixes

* **types:** fix incorrect types generation ([f5613da](f5613da)), closes [#113](#113)
@github-actions
Copy link

🎉 This issue has been resolved in version 4.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgtsquiggs sgtsquiggs

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect types generation batoulapps/adhan-js
2 participants
@sgtsquiggs @jd1378