-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload Pipeline: test older containers #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @arifogel, @dhalperi, and @sfraint)
.buildkite/pipeline.sh
line 257 at r1 (raw file):
# Get available Pybatfish versions from PyPI python -m pip install --user 'requests==2.23.0' >/dev/null PYBF_TAGS=$(python -c "import requests; print('\n'.join(requests.get('https://pypi.python.org/pypi/pybatfish/json').json()['releases'].keys()))" | sort -r)
This isn't right for pybf yet, since months and days are canonicalized to drop leading zeros
Code quote:
| sort -r
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @arifogel and @dhalperi)
.buildkite/pipeline.sh
line 257 at r1 (raw file):
$ python -c "
> from datetime import datetime
> import requests
> releases = requests.get('https://pypi.python.org/pypi/pybatfish/json').json()['releases'].keys()
> print('\n'.join(sorted(releases, key=lambda x: datetime.strptime(x, '%Y.%m.%d.%f'), reverse=True)))
> "
2022.3.16.1242
2022.2.18.1216
2021.11.4.1095
2021.7.9.974
2021.4.12.882
2021.2.26.830
2020.12.23.763
2020.10.8.667
2020.8.11.600
2020.4.23.480
2020.2.20.414
2020.2.3.395
2020.1.11.363
2019.11.20.299
2019.11.5.282
2019.11.1.277
2019.11.1.276
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @arifogel and @sfraint)
.buildkite/pipeline.sh
line 27 at r2 (raw file):
BATFISH_VERSION_STRING="${BATFISH_VERSION_STRING:-$(date +'%Y.%m.%d').${BUILDKITE_BUILD_NUMBER}}" # Only test Bf containers less than this many days old
I'd reword this to more accurately represent what's up?
Code quote:
Only test Bf containers less than this many days old
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @arifogel and @dhalperi)
.buildkite/pipeline.sh
line 27 at r2 (raw file):
Previously, dhalperi (Dan Halperin) wrote…
I'd reword this to more accurately represent what's up?
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)
n
Batfish releases andm
Pybatfish releases, regardless of their age