Skip to content

Conversation

@Cornelius-G
Copy link
Collaborator

WIP

  • need to add a bit more support for NamedTuples
  • need to do some minor adaptions & clean-up
  • @oschulz: I did not (yet) add a FixedBinning type since I actually wanted the binning to accept Integerand Ranges directly without wrapping into a special type, so that e.g. plot(samples, bins=(50, -10:0.5:10, SqrtBinning()) is possible (which it is now).
    So currently we accept something like (tuples of) Union{Integer, AbstractRange, AbstractBinning}.
    In Add BinningAlgorithm algo type #166 you mentioned Base.convert could be helpful, but it seems I do not fully understand how this would improve the usability, so maybe you could explain how we should handle this.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

❌ Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.43%. Comparing base (f5342a8) to head (9957479).
⚠️ Report is 705 commits behind head on main.

Files with missing lines Patch % Lines
src/algotypes/binning_algorithm.jl 0.00% 56 Missing ⚠️
src/plotting/MarginalDist.jl 0.00% 6 Missing ⚠️
src/optimization/mode_estimators.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   45.06%   44.43%   -0.63%     
==========================================
  Files          89       90       +1     
  Lines        4613     4658      +45     
==========================================
- Hits         2079     2070       -9     
- Misses       2534     2588      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants