Skip to content

Commit

Permalink
Fix compiling with -fno-common
Browse files Browse the repository at this point in the history
GCC 10 will enable -fno-common by default[0], which causes the linker to fail like this [1]:

`ld: pinfo-colors.o:(.bss+0x34): multiple definition of `use_manual'; pinfo-pinfo.o:(.bss+0x10): first defined here`

Fix this by removing the extraneous definition from `parse_config.h`.

[0] https://gcc.gnu.org/gcc-10/porting_to.html#common
[1] https://bugs.gentoo.org/706548
  • Loading branch information
jer-gentoo authored Jan 27, 2020
1 parent d950ae5 commit fc4ad0b
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/parse_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ typedef struct colours
colours;
#endif /* HAVE_CURSES_COLOR */

int use_manual;

int parse_config (void);
int parse_line (char *line);
char *str_toupper (char *s);
Expand Down

0 comments on commit fc4ad0b

Please sign in to comment.