Trick list overview #302
Open
Trick list overview #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When refreshing the page the app crashes with the error message 'Uncaught (in promise) RangeError: Invalid array length'. I guess this might be a problem with my 'onMounted' method?
…rick Overview be async
|
Let me know what you think of the design and if you have any improvements |
Closed
bastislack
approved these changes
Nov 24, 2023
| } | ||
| } | ||
| }; | ||
| </script> |
There was a problem hiding this comment.
Just wondering: Why are there two <script> tags and both have different formats on how methods are declared?
| <Card> | ||
| <CardHeader> | ||
| <CardTitle>{{ trick.alias && trick.alias.length > 0 ? trick.alias : trick.technicalName }}</CardTitle> | ||
| <CardDescription>Registred by: {{ trick.establishedBy }}</CardDescription> |
There was a problem hiding this comment.
I think the description is not needed here. I would prefer just having the name of the trick :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Enhance the Trick List UI
What was done to achieve it?
<Card />and<Collapsible />components