-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable lat/lon coordinates #7
Comments
Maybe just use https://github.com/mapbox/cheap-ruler to convert lon/lat to local XYZ (ENU) coordinates reference system. (I did similar thing here) Did you benchmarked your point-in-polygon. I used to use point-in-polygon test from GEOS/shapely, but found out that |
About the lat/lon: I think it is not so simple because it's not just about converting coordinates but then the question whether a point is on the one side or the other side of a "line" changes since lines become "curved". About the benchmarking: I ran benchmarks but did not compare much with other codes. What is the size of the system that you have used to benchmark GEOS/shapely? (how many polygons, how many points) |
Seems you are right. I thought Yeah, when your use cases involves bigger area (1000km+ maybe), you can't just choose one ENU (or latitude, like cheap-ruler did).
Benchmarking is tricky, I created some random points (10,000) and random polygons (30% of whole area), tests show that matplotlib version is always 50x times faster (same result). code here: https://fast-crossing.readthedocs.io/en/latest/point-in-polygon/ |
I agree that for smaller distances your approach is fine but we use this for coastlines and there the distances can be significant. The benchmarks are interesting. I use |
Collecting some notes/reading material:
The text was updated successfully, but these errors were encountered: