Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1434 in MQTT + MQTT Unittests #1435

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix 1434 in MQTT + MQTT Unittests #1435

wants to merge 3 commits into from

Conversation

motzky
Copy link
Contributor

@motzky motzky commented Jan 3, 2025 •
edited
Loading

Handle HTTP/404 and CarId < 0 in MQTT

fixes #1434

@motzky motzky changed the title Handle HTTP/404 and CarId < 0 in MQTT WIP: Fix 1434 in MQTT Jan 3, 2025
@bassmaster187
Copy link
Owner

Still WIP?

@motzky
Copy link
Contributor Author

motzky commented Jan 3, 2025

Yes. Needs testing, since I couldn’t reproduce in my environment yet

@motzky motzky marked this pull request as ready for review January 3, 2025 20:58
@motzky
Copy link
Contributor Author

motzky commented Jan 3, 2025

Should be ready now.
Had to do quite some refactoring in MQTT for Moq to work adequately in unit tests.
The good news is that the linked issue does seem fixed in the tests.

@Adminius please have a look also.

@motzky motzky changed the title WIP: Fix 1434 in MQTT Fix 1434 in MQTT + MQTT Unittests Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MQTT spams log with 404 exception every minute
2 participants
@motzky @bassmaster187