Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing spaces in const.py: restore correct one, remove incorrect one #1148

Merged

Conversation

marazmarci
Copy link
Contributor

@marazmarci marazmarci commented Jan 1, 2025

Sorry, my previous PR didn't fix the issue with the failing workflows, as I removed the trailing space from the wrong place... 😅

Now I fixed it and removed the right one(s). I had to touch translation JSONs, and I'm not sure if they can be edited directly, or it will cause problems with Weblate.

Update: as you can see, now the workflow now really succeeds!

(caused by home-assistant/core#126446)

@marazmarci marazmarci requested a review from basnijholt as a code owner January 1, 2025 21:08
@marazmarci marazmarci marked this pull request as draft January 1, 2025 21:15
@marazmarci marazmarci marked this pull request as ready for review January 1, 2025 21:27
@basnijholt basnijholt merged commit 2e2b9e5 into basnijholt:main Jan 1, 2025
24 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants