feature: make consumer name nullable in consumer configuration

README.md

@@ -198,7 +198,7 @@ $goodbyer
 use Basis\Nats\Consumer\Configuration as ConsumerConfiguration;
 use Basis\Nats\Consumer\DeliverPolicy;
 
-$configuration = (new ConsumerConfiguration($stream->getName(), ''))
+$configuration = (new ConsumerConfiguration($stream->getName()))
     ->setDeliverPolicy(DeliverPolicy::NEW)
     ->setSubjectFilter('mailer.greet');
 

src/Consumer/Configuration.php

@@ -26,7 +26,7 @@ class Configuration
 
     public function __construct(
         private readonly string $stream,
-        private string $name
+        private ?string $name = null
     ) {
     }
 
@@ -35,7 +35,7 @@ public function getAckPolicy(): string
         return $this->ackPolicy;
     }
 
-    public function getName(): string
+    public function getName(): ?string
     {
         return $this->name;
     }
@@ -185,7 +185,7 @@ public function toArray(): array
             'deliver_policy' => $this->getDeliverPolicy(),
             'deliver_subject' => $this->getDeliverSubject(),
             'description' => $this->getDescription(),
-            'durable_name' => $this->isEphemeral() ?  null : $this->getName(),
+            'durable_name' => $this->isEphemeral() ? null : $this->getName(),
             'flow_control' => $this->getFlowControl(),
             'headers_only' => $this->getHeadersOnly(),
             'idle_heartbeat' => $this->getIdleHeartbeat(),

src/Consumer/Consumer.php

@@ -24,7 +24,7 @@ public function __construct(
 
     public function create($ifNotExists = true): self
     {
-        if (!$this->exists()) {
+        if ($this->shouldCreateConsumer($ifNotExists)) {
             $command = $this->configuration->isEphemeral() ?
                 'CONSUMER.CREATE.' . $this->getStream() :
                 'CONSUMER.DURABLE.CREATE.' . $this->getStream() . '.' . $this->getName();
@@ -191,4 +191,10 @@ public function setIterations(int $iterations): self
 
         return $this;
     }
+
+    private function shouldCreateConsumer(bool $ifNotExists): bool
+    {
+        return ($this->configuration->isEphemeral() && $this->configuration->getName() === null)
+            || !$this->exists();
+    }
 }

tests/Functional/StreamTest.php

@@ -245,10 +245,14 @@ public function testEphemeralConsumer()
 
         $this->called = null;
 
-        $configuration = new Configuration('my_stream', '');
+        $configuration = new Configuration('my_stream');
         $configuration->setSubjectFilter('tester.greet');
         $consumer1 = $stream->createEphemeralConsumer($configuration);
         $this->assertNull($this->called);
+
+        // check that consumer can be received by name after creation
+        $this->assertSame($consumer1, $stream->getConsumer($consumer1->getName()));
+
         $consumer1->setIterations(1);
         $consumer1->handle($this->persistMessage(...));
 
@@ -261,7 +265,7 @@ public function testEphemeralConsumer()
         $this->assertSame($this->called->name, 'oxidmod');
 
         $this->called = null;
-        $configuration = new Configuration('my_stream', '');
+        $configuration = new Configuration('my_stream');
         $configuration->setSubjectFilter('tester.bye')->setAckPolicy('explicit');
         $consumer2 = $stream->createEphemeralConsumer($configuration);