Code converted into Object Oriented Approach#1
Open
emekgozluklu wants to merge 4 commits intobasiralab:masterfrom
Open
Code converted into Object Oriented Approach#1emekgozluklu wants to merge 4 commits intobasiralab:masterfrom
emekgozluklu wants to merge 4 commits intobasiralab:masterfrom
Conversation
nested functions are not usable. using class based approach instead, makes things easier and more useful owing to methods, shared variables etc. Also, people might want to integrate this class to their own projects. It is not possible to do so with nested function structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the nested function structure is not useful, I changed the code using Object Oriented Approach. It provides:
Missing requirements.txt and .gitignore files are added.